Optimize rendering performance in MiniMap#2
Merged
Conversation
- AnyMiniMapEntity: replace heap-allocated closures with directly stored values, eliminating per-access indirection and allocation overhead - updateEntityPositions: reuse existing SKShapeNode markers instead of removing and recreating every call; nodes are only reallocated when markerRadius changes (baked into the path), which avoids per-frame GPU resource churn for games with a stable entity count - updateCameraViewFrame: pre-compute scaleX/scaleY once per call and derive the viewport rectangle from four scalar clamps instead of constructing eight intermediate CGPoint structs https://claude.ai/code/session_018t9xFejpw1oNq4KkKhKagR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnyMiniMapEntity: replace heap-allocated closures with directly stored
values, eliminating per-access indirection and allocation overhead
updateEntityPositions: reuse existing SKShapeNode markers instead of
removing and recreating every call; nodes are only reallocated when
markerRadius changes (baked into the path), which avoids per-frame GPU
resource churn for games with a stable entity count
updateCameraViewFrame: pre-compute scaleX/scaleY once per call and
derive the viewport rectangle from four scalar clamps instead of
constructing eight intermediate CGPoint structs
https://claude.ai/code/session_018t9xFejpw1oNq4KkKhKagR