Add marker shapes, ping animation, visibility toggle, and iOS touch support#3
Open
Atothendrew wants to merge 2 commits into
Open
Add marker shapes, ping animation, visibility toggle, and iOS touch support#3Atothendrew wants to merge 2 commits into
Atothendrew wants to merge 2 commits into
Conversation
…upport Marker shapes (MiniMapMarkerShape): - New .circle (default), .square, .diamond, .triangle enum - markerShape added to MiniMapEntity protocol with .circle default - AnyMiniMapEntity stores the shape; makeMarkerNode(for:) builds the correct SKShapeNode path; reuse logic only recreates when radius or shape changes Ping animation (showPing(at:color:duration:)): - Expanding, fading ring at any scene coordinate, clamped to map bounds - No-ops silently when sceneSize is not yet known Visibility toggle (setVisible(_:animated:)): - 0.3 s cross-fade by default; instant when animated: false - contains(_:) returns false while isHidden — no stale click capture iOS / tvOS touch convenience methods: - handleTouchBegan(at:in:), handleTouchMoved(to:in:), handleTouchEnded(at:in:) - Mirror the macOS mouse API; support drag, resize, and click https://claude.ai/code/session_018t9xFejpw1oNq4KkKhKagR
macos-latest runners in 2026 ship with Xcode 16.x; Xcode_15.0.app no longer exists, causing the xcode-select step to fail immediately. Drop the version pin and use the runner's default Xcode instead. https://claude.ai/code/session_018t9xFejpw1oNq4KkKhKagR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniMapMarkerShape— new.circle(default),.square,.diamond,.triangleenum; addedmarkerShapetoMiniMapEntityprotocol andAnyMiniMapEntity; node-reuse logic recreates markers only when shape or radius changesshowPing(at:color:duration:)— displays a pulsing, expanding ring at any scene coordinate on the mini-map; clamped to map bounds; auto-removes when the animation completes; silently no-ops if scene size is not yet setsetVisible(_:animated:)— fades in/out over 0.3 s by default (instant withanimated: false);contains(_:)now respectsisHiddenso hidden maps never capture clickshandleTouchBegan(at:in:),handleTouchMoved(to:in:),handleTouchEnded(at:in:)mirror the existing macOS mouse API with identical drag/resize/click semanticsTest plan
MiniMapMarkerShapevalues round-trip correctly throughAnyMiniMapEntityshowPingno-ops whenupdateEntityPositionshas not yet been calledsetVisible(false)preventscontainsfrom returning truehttps://claude.ai/code/session_018t9xFejpw1oNq4KkKhKagR
Generated by Claude Code