Fix URL corruption caused by HTML escaping#1124
Open
SyntaxNyah wants to merge 1 commit into
Open
Conversation
URLs containing & for example discord and stuff were being corrupted because toHtmlEscaped() was called before URL detection, turning & into amp. inside link hrefs. This shit has been pissing me off for far too long. This fix detects urls on the raw message then html escapes only the non url text. Applied to server descriptions and OOC chat. Heres a screenshot of me building the client and testing it and yes the discord link downloaded.
Author
|
I hate QT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs containing & for example discord and stuff were being corrupted because toHtmlEscaped() was called before
URL detection, turning & into amp. inside link hrefs.
This shit has been pissing me off for far too long. This fix detects urls on the raw message then html escapes only the non url text. Applied to server descriptions and OOC chat. Heres a screenshot of me building the client and testing it and yes the discord link downloaded instead of being an invalid & link at least. It works and functions.
If merged this would close this #1116 issue. Feel free to review if people want to improve this or just merge as is do what you like. It does build though.