Skip to content

perf(api): align trending ids query with index order #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymondjacobson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(api): align trending ids query with index order #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions api/v1_tracks_trending_ids.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,18 @@ import (

func (app *ApiServer) getTrendingIds(c *fiber.Ctx, timeRange string, genre string, limit int, offset int) ([]int32, error) {
sql := `
SELECT track_trending_scores.track_id
FROM track_trending_scores
LEFT JOIN tracks
ON tracks.track_id = track_trending_scores.track_id
AND tracks.is_delete = false
AND tracks.is_unlisted = false
AND tracks.is_available = true
WHERE type = 'TRACKS'
AND version = 'pnagD'
AND time_range = @time
AND (@genre = '' OR track_trending_scores.genre = @genre)
ORDER BY
score DESC,
track_id DESC
LIMIT @limit
OFFSET @offset
`
SELECT track_trending_scores.track_id
FROM track_trending_scores
WHERE type = 'TRACKS'
AND version = 'pnagD'
AND time_range = @time
AND (@genre = '' OR track_trending_scores.genre = @genre)
ORDER BY
score DESC,
track_id DESC
LIMIT @limit
OFFSET @offset
`

args := pgx.NamedArgs{}
args["limit"] = limit
Expand Down
6 changes: 6 additions & 0 deletions ddl/migrations/0218_track_trending_scores_desc_tiebreak_idx.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
-- Hot trending endpoints order by score desc, track_id desc. The existing
-- ix_trending_scores index has track_id in ascending order, which leaves
-- PostgreSQL doing an incremental sort for every request. Keep API tie-break
-- behavior stable by adding an index whose order matches the query.
CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_trending_scores_desc_tiebreak
ON track_trending_scores (type, version, time_range, score DESC, track_id DESC);
Loading