Improve performance of GetConfigurationChanges (parallel fetch + O(N+M) lookup)#23
Open
ruodanxie wants to merge 1 commit into
Open
Improve performance of GetConfigurationChanges (parallel fetch + O(N+M) lookup)#23ruodanxie wants to merge 1 commit into
ruodanxie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the performance of
AppConfigurationImporter.GetConfigurationChangesthrough two internal changes. Public API surface, return value shape, and observable behavior are unchanged for all existing source types and scenarios.Motivation
Currently, for example, when importing from configuration file which has 2000 KVs and target store has 3 KVs, total time taken is 1.36s nearly. However, when importing from configuration file which has 2000 KVs and target store also has 2000 KVs, it took 12s approximately. There is room for optimization.
The following are the reasons why running GetConfigurationChanges is currently slow:
Array.find+Array.spliceon the source array for every target item, producing O(N × M) complexity that degrades quickly when both stores grow.Changes
All changes are internal to
GetConfigurationChangesinlibraries/azure-app-configuration-importer/src/appConfigurationImporter.ts.1. Parallel source and target fetch
sourcePromise(sourceGetConfigurationSettings()) andtargetPromise(target storelistConfigurationSettings) are now kicked off at the same time and awaited later.2. O(N + M) diff using
MapandSetsrcKeyLabelLookUp[key][label]) withsrcMap: Map<"key\u0000label", incoming>.configurationSettingToAdd(array +Array.find+splice(indexOf(...))) withtoAddKeys: Set<"key\u0000label">.\u0000) as the separator since it cannot appear in App Configuration keys or labels, guaranteeing uniqueness.Version bump
Bumps
libraries/azure-app-configuration-importerfrom3.0.0-previewto3.0.0-preview.2(next preview iteration; no public API additions).