fix: Render empty subscription arrays correctly (#4195) - #140
Open
Omansh5 wants to merge 1 commit into
Open
Conversation
Omansh5
requested review from
Qi Zhang (Zhangqi910),
Akshay Rohilla (akshayrohilla),
OmairAbdullah (omairabdullah) and
Shiva Sai Yeddlapuri (yeddlapurishivasai)
and
a lite review from Copilot
August 7, 2026 09:38
There was a problem hiding this comment.
Pull request overview
This PR addresses Bug #4195 by adjusting the Bicep .bicepparam templating pipeline to render empty subscription arrays as [] (instead of ['']) after template rendering, while leaving populated subscription arrays unchanged.
Changes:
- Post-processes rendered
.bicepparamcontent to convert['']to[]. - Keeps the existing escaping/unescaping flow around
templatestring()intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR fixes Bug #4195 by correctly rendering empty subscription arrays for optional platform subscriptions in the generated Bicep parameter files.
Previously, when the Identity or Security subscription IDs were left empty, the generated
.bicepparamfiles contained:This PR updates the rendering logic so that empty subscription values are rendered as:
subscriptionsToPlaceInManagementGroup: []while preserving valid subscription IDs.
This PR fixes/adds/changes/removes
modules/file_manipulation/locals.bicep.tf.['']to[]after template rendering.Validation
Validation was performed using the ALZ Accelerator with the following configuration:
Verified that:
subscriptionsToPlaceInManagementGroup: []subscriptionsToPlaceInManagementGroup: []['']remain in the generatedlocal-outputfiles..bicepparamfiles.Fixes #4195