-
Notifications
You must be signed in to change notification settings - Fork 346
Allow multi-segment runtime REST/GraphQL paths (e.g. /api/v2) #3684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
main
Choose a base branch
from
copilot/fix-multi-segment-paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -343,11 +343,12 @@ public void TestUpdateDepthLimitInGraphQLRuntimeSettings(string depthLimit, bool | |
| [DataRow("/updatedPath", true, DisplayName = "Success in updated GraphQL Path to /updatedPath.")] | ||
| [DataRow("/updated-Path", true, DisplayName = "Success in updated GraphQL Path to /updated-Path.")] | ||
| [DataRow("/updated_Path", true, DisplayName = "Success in updated GraphQL Path to /updated_Path.")] | ||
| [DataRow("/api/v2", true, DisplayName = "Success in updated GraphQL Path to multi-segment path /api/v2.")] | ||
| [DataRow("updatedPath", false, DisplayName = "Failure due to '/' missing.")] | ||
| [DataRow("/updated Path", false, DisplayName = "Failure due to white spaces.")] | ||
| [DataRow("/updated.Path", false, DisplayName = "Failure due to reserved char '.'.")] | ||
| [DataRow("/updated@Path", false, DisplayName = "Failure due reserved chars '@'.")] | ||
| [DataRow("/updated/Path", false, DisplayName = "Failure due reserved chars '/'.")] | ||
| [DataRow("/api//v2", false, DisplayName = "Failure due to empty path segment.")] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as previous comment |
||
| public void TestUpdateGraphQLPathRuntimeSettings(string path, bool isSuccess) | ||
| { | ||
| // Initialize the config file. | ||
|
|
@@ -405,11 +406,12 @@ public void TestUpdateHostCorsOriginsRuntimeSettings(string path, bool isSuccess | |
| [DataRow("/updatedPath", true, DisplayName = "Successfully updated Rest Path to /updatedPath.")] | ||
| [DataRow("/updated-Path", true, DisplayName = "Successfully updated Rest Path to /updated-Path.")] | ||
| [DataRow("/updated_Path", true, DisplayName = "Successfully updated Rest Path to /updated_Path.")] | ||
| [DataRow("/api/v2", true, DisplayName = "Successfully updated Rest Path to multi-segment path /api/v2.")] | ||
| [DataRow("updatedPath", false, DisplayName = "Failure due to '/' missing.")] | ||
| [DataRow("/updated Path", false, DisplayName = "Failure due to white spaces.")] | ||
| [DataRow("/updated.Path", false, DisplayName = "Failure due to reserved char '.'.")] | ||
| [DataRow("/updated@Path", false, DisplayName = "Failure due reserved chars '@'.")] | ||
| [DataRow("/updated/Path", false, DisplayName = "Failure due reserved chars '/'.")] | ||
| [DataRow("/api//v2", false, DisplayName = "Failure due to empty path segment.")] | ||
| public void TestUpdateRestPathRuntimeSettings(string path, bool isSuccess) | ||
| { | ||
| // Initialize the config file. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1683,6 +1683,14 @@ private static void ValidateExceptionForDuplicateQueriesDueToEntityDefinitions(S | |
| DisplayName = "GraphQL path prefix containing space at the start and underscore in between.")] | ||
| [DataRow("/", null, ApiType.REST, false, | ||
| DisplayName = "REST path containing only a forward slash.")] | ||
| [DataRow("/api/v2", null, ApiType.REST, false, | ||
| DisplayName = "REST path containing multiple segments.")] | ||
| [DataRow("/api/v2", null, ApiType.GraphQL, false, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as previous comment |
||
| DisplayName = "GraphQL path containing multiple segments.")] | ||
| [DataRow("/api/", $"REST path {RuntimeConfigValidatorUtil.URI_COMPONENT_WITH_RESERVED_CHARS_ERR_MSG}", ApiType.REST, true, | ||
| DisplayName = "REST path containing a trailing slash.")] | ||
| [DataRow("/api//v2", $"REST path {RuntimeConfigValidatorUtil.URI_COMPONENT_WITH_RESERVED_CHARS_ERR_MSG}", ApiType.REST, true, | ||
| DisplayName = "REST path containing an empty segment.")] | ||
| public void ValidateApiURIsAreWellFormed( | ||
| string apiPathPrefix, | ||
| string expectedErrorMessage, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Think it would be better to use a different name than
apisince that is the default we use for REST paths. I think it is better to usegraphql