Add metalman RAID1 and HTTP boot support#418
Draft
imiller31 wants to merge 5 commits into
Draft
Conversation
jveski
reviewed
Jul 8, 2026
| // when set and otherwise falls back to targetDisk or automatic selection. | ||
| // Examples: /dev/nvme0n1, /dev/sda, /dev/disk/by-id/... | ||
| // +optional | ||
| TargetDisks []string `json:"targetDisks,omitempty"` |
Contributor
There was a problem hiding this comment.
Let's either remove the TargetDisk field or swap this one into its place. It was just merged yesterday so barely a breaking change at all
| // +kubebuilder:validation:Enum=Raw;RAID1 | ||
| // +kubebuilder:default=Raw | ||
| // +optional | ||
| Mode string `json:"mode,omitempty"` |
Contributor
There was a problem hiding this comment.
Maybe RAIDMode instead? In case some modes can be combined in the future.
| @@ -1,8 +1,8 @@ | |||
| #!/bin/sh | |||
Contributor
There was a problem hiding this comment.
This script is getting pretty complex - time for a go binary? Doesn't need to be in this PR although it might help with testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes