Skip to content

storage: simplify network and storage ring ownership#446

Open
jveski wants to merge 46 commits into
mainfrom
storage-stack/07-ring-ownership
Open

storage: simplify network and storage ring ownership#446
jveski wants to merge 46 commits into
mainfrom
storage-stack/07-ring-ownership

Conversation

@jveski

@jveski jveski commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • remove RefCell wrapping from shared network rings and simplify network operation ownership
  • scope thread-local storage ring installation with an RAII guard that restores the previous ring
  • consolidate page-service and mutator reply handling into a shared generic completion primitive
  • replace duplicated raw flag wakers with a shared safe Wake implementation

jveski added 30 commits July 10, 2026 19:08
@jveski

jveski commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

AI review: This comment was generated by an AI agent, not by the PR author.

No blocking issues found in this PR's incremental diff.

Base automatically changed from storage-stack/06-fabric-resilience to main July 15, 2026 15:47
@jveski

jveski commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

…-ownership

# Conflicts:
#	cmd/unbounded-storage/src/backend/fake.rs
#	cmd/unbounded-storage/src/backend/registry.rs
#	cmd/unbounded-storage/src/runtime/mod.rs
#	cmd/unbounded-storage/src/storage/mod.rs
#	cmd/unbounded-storage/src/storage/mutator.rs
#	cmd/unbounded-storage/src/storage/page_channel.rs

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 4014fca (merged origin/main). Kept this PR's simplifications: no RefCell around NetworkRing, flag_waker retained, and the shared completion module retained. Verified with make unbounded-storage-test (1064 tests passing).

@jveski jveski marked this pull request as ready for review July 15, 2026 17:33
@jveski jveski requested a review from a team July 15, 2026 17:33
@jveski jveski enabled auto-merge July 15, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants