Skip to content

add hasAuthorsAtR field in dbMat#11

Open
LiNk-NY wants to merge 3 commits into
develfrom
authorsAtR
Open

add hasAuthorsAtR field in dbMat#11
LiNk-NY wants to merge 3 commits into
develfrom
authorsAtR

Conversation

@LiNk-NY

@LiNk-NY LiNk-NY commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Hi Lori, @lshep

It would be good to include the hasAuthorsAtR field in the VIEWS file.
This would help us identify more easily what packages need to use this field in the DESCRIPTION file.

https://bioconductor.org/packages/release/bioc/VIEWS
https://bioconductor.org/packages/devel/bioc/VIEWS

related to: seandavi/BiocPkgTools#65

@lshep

lshep commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

we'll need to test this to make sure it works properly since if the VIEWS files does not get generated it will block updates and landing page generation on the website for packages.

@LiNk-NY LiNk-NY requested a review from lshep August 21, 2024 14:04
@lshep

lshep commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@jwokaty with the reorg of code is this run by the central builder on jetstream?

@hpages

hpages commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

It is run on the central builder in the biocpush account but biocViews will need to be updated manually there.

@LiNk-NY It should be:

identical(length(field), 1L) && !is.na(field) 

rather than:

!is.na(field) && identical(length(field), 1L)

If length(field) happens to be != 1 then !is.na(field) will be a logical vector of length !=1 which will cause problems in the context of &&. By putting it after the && it will only be evaluated if length(field) is 1.

Also no need to use identical() here, length(field) == 1L is just fine and more natural.

@LiNk-NY LiNk-NY force-pushed the authorsAtR branch 2 times, most recently from 3d6faed to 45a73a7 Compare December 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

3 participants