feat: add sdk-core vault module interfaces and scaffolding #9223
Open
davidkaplanbitgo wants to merge 4 commits into
Open
feat: add sdk-core vault module interfaces and scaffolding #9223davidkaplanbitgo wants to merge 4 commits into
davidkaplanbitgo wants to merge 4 commits into
Conversation
Net-new sdk-core/src/bitgo/vault module mirroring the EnterpriseData/ Enterprise and WalletData/Wallet conventions: iVault/iVaults interfaces (per API Changes v1 §3), the Vault and Vaults classes, and the barrel. Vault implements getters, url(), toJSON(), and freeze/archive REST plumbing; createWallet, member, and share methods are stubbed for WCN-1203/WCN-1204. Vaults lifecycle methods (createVault, initialize, finalize, list, get) are stubbed pending Phase 2/3 (WCN-1175/1177). Wires an Enterprise.vaults() accessor and the bitgo barrel export. WCN-1192 TICKET: WCN-1192
Contributor
davidkaplanbitgo
force-pushed
the
WCN-1192.vault-interfaces
branch
from
25318da to
7da4e23
Compare
Contributor
|
Flush,CI Failing |
OttoAllmendinger
requested changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
shouldn't these live in a shared package? doesn't the backend use the same types?
OttoAllmendinger
requested changes
Jul 10, 2026
| import { EnterpriseData, EnterpriseFeatureFlag, IEnterprise } from '../enterprise'; | ||
| import { getFirstPendingTransaction } from '../internal'; | ||
| import { ListWalletOptions, Wallet } from '../wallet'; | ||
| import { Safes } from '../safe'; |
Contributor
There was a problem hiding this comment.
my understanding is that the name should be "Vaults" not "Safes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net-new sdk-core/src/bitgo/vault module mirroring the EnterpriseData/
Enterprise and WalletData/Wallet conventions: iVault/iVaults interfaces
(per API Changes v1 §3), the Vault and Vaults classes, and the barrel.
Vault implements getters, url(), toJSON(), and freeze/archive REST
plumbing; createWallet, member, and share methods are stubbed for
WCN-1203/WCN-1204. Vaults lifecycle methods (createVault, initialize,
finalize, list, get) are stubbed pending Phase 2/3 (WCN-1175/1177).
Wires an Enterprise.vaults() accessor and the bitgo barrel export.
WCN-1192