Add provisional BIP44 coin type metadata - #123
Closed
mtg0001 wants to merge 3 commits into
Closed
Conversation
mtg0001
force-pushed
the
bip44-coin-type
branch
from
August 3, 2026 15:49
20dafb6 to
f31644a
Compare
Contributor
Author
|
Manual smoke test on the PR branch, without merging and with a disposable datadir:
Automated checks also passed:
This does not claim full BIP44 wallet behavior yet. It only verifies this preparation PR: metadata persistence, audit visibility, path helper coverage, and unchanged legacy derivation behavior. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4346950, with the intended SLIP-0044 registry row4346950 | BITFLASH | Bitflashuntil an official entry exists.hdcointypealongside the HD wallet schema metadata, while inferring old seeded wallets to the provisional value in memory.m/index'derivation through the shared BIP32 path engine without changing wallet behavior.Why
SLIP-0044 currently has
FLASHassigned to Flashcoin andBTFassigned to Bitcoin Faith, and no Bitflash entry. Reusing either would be worse than being explicit. This PR usesBITFLASHas the proposed registry symbol and keeps the value provisional and stored as metadata so preview wallets remain recoverable even if an official coin type is assigned later.This is still preparation only: the wallet continues to use the legacy schema and this build still refuses to operate a BIP44-schema wallet until the actual BIP44 derivation/restore PR lands.
Stack
Stacked after #121 and #122.
Testing
git diff --checkmingw32-make -f makefile.mingw testsfrom MSYS2 UCRT64 insrc/