Deduplicate and expand compiler references to resolve conflict on mod - #5
Open
leonardo-spy wants to merge 2 commits into
Open
Deduplicate and expand compiler references to resolve conflict on mod#5leonardo-spy wants to merge 2 commits into
leonardo-spy wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
The new runtime-directory reference scan can still introduce duplicate assembly identities and currently swallows all exceptions, which can mask real failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the mod compilation pipeline’s Roslyn reference collection so mod builds have a more complete (and less duplicated) set of MetadataReferences, helping avoid reference-resolution conflicts during mod compilation.
Changes:
- Deduplicates assembly file references gathered from
AppDomain.CurrentDomain.GetAssemblies()via aHashSet. - Expands reference discovery by scanning the .NET runtime directory for additional managed
*.dllfiles.
File summaries
| File | Description |
|---|---|
| RecompOne.Runtime/Modding/ModCompiler.cs | Enhances and deduplicates the Roslyn reference list used for runtime mod compilation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.