plugin: Add GET_PER_COMMITMENT_POINT to stuck HSM types#725
Merged
Conversation
Type 18 (WIRE_HSMD_GET_PER_COMMITMENT_POINT) is used by onchaind to derive historical commitment keys during force-close resolution. If the signer doesn't respond it blocks block processing just like the signing types already in the list. Observed on several deeply-lagged nodes where onchaind fires for a closing channel and gets stuck on a GET_PER_COMMITMENT_POINT request before the 10-minute bgsync preemption kicks in. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cdecker
force-pushed
the
detect-stuck-bgsync-nodes
branch
from
97881e5 to
b7d8e45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #724. Type 18 (
WIRE_HSMD_GET_PER_COMMITMENT_POINT) is used by onchaind to derive historical commitment keys during force-close resolution. If the signer doesn't respond it blocks block processing just like the signing types added in the previous PR.Context
Inspecting the 10 worst-lagged bgsync nodes revealed 3 additional nodes stuck on type 18 — onchaind fires when hitting the block where a channel closed and requests historical per-commitment points to reconstruct keys for the HTLC sweep. The signerproxy can't fulfil these in the current bgsync sessions, so the node blocks for the full 10-minute window.
Test plan
stuck_request_types()returns[18]when aGET_PER_COMMITMENT_POINTrequest is pending and unanswered🤖 Generated with Claude Code