add(staff-association): new model and transformation rules#391
Open
zubeydecivelek wants to merge 1 commit into
Open
add(staff-association): new model and transformation rules#391zubeydecivelek wants to merge 1 commit into
zubeydecivelek wants to merge 1 commit into
Conversation
zubeydecivelek
force-pushed
the
staff-assoc
branch
from
08ed04c to
888e70b
Compare
1 task
zubeydecivelek
commented
Mar 19, 2026
zubeydecivelek
commented
Mar 19, 2026
zubeydecivelek
commented
Mar 19, 2026
Comment on lines
+61
to
+63
| if value == "bulletinstaff": | ||
| # TODO what is the resource type? | ||
| return {"id": "publication-periodicalarticle"} |
Contributor
Author
There was a problem hiding this comment.
Is resource_type correct?
Contributor
There was a problem hiding this comment.
are there only articles in the data set or also issues? if there are issues, we can't assign article resource type to an issue
kpsherva
reviewed
Mar 19, 2026
zubeydecivelek
force-pushed
the
staff-assoc
branch
2 times, most recently
from
cd7693e to
ec6be3c
Compare
kpsherva
reviewed
May 8, 2026
kpsherva
reviewed
May 8, 2026
| "110__a", # corporate author, always CERN, safe to ignore | ||
| "300__a", # number of pages | ||
| "336__a", # DM metadata | ||
| "506__m", # 2120833, ignored with confirmation from IR-ECO-CO |
Contributor
There was a problem hiding this comment.
does it mean we need to ask them?
Contributor
Author
There was a problem hiding this comment.
Ignore keys are copied from bulletin. But I can check them again and verify with library if it's needed
Contributor
Author
There was a problem hiding this comment.
I checked the rules, 506__m doesnt exist for staff association. But we need to figure out multiple submitters, most of the records(2595/3306) have 859__a with different values.
kpsherva
reviewed
May 8, 2026
zubeydecivelek
force-pushed
the
staff-assoc
branch
2 times, most recently
from
ae3d8bb to
2da547f
Compare
zubeydecivelek
commented
May 15, 2026
zubeydecivelek
force-pushed
the
staff-assoc
branch
from
2da547f to
5e9156f
Compare
Co-Authored-By: Saksham <sakshamarora1001@gmail.com>
sakshamarora1
force-pushed
the
staff-assoc
branch
from
5e9156f to
040f165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #533
No records found with
scripts/dump_legacy_recids_to_redirect.py