config: add flag to update publication date for new version#538
Open
0einstein0 wants to merge 2 commits into
Open
config: add flag to update publication date for new version#5380einstein0 wants to merge 2 commits into
0einstein0 wants to merge 2 commits into
Conversation
| stream_config = config.get(definition.name) or {} | ||
| self.data_dir = Path(stream_config[collection].get("data_dir")) | ||
| self.restricted = stream_config[collection].get("restricted", False) | ||
| self.update_publication_date = stream_config[collection].get( |
Contributor
There was a problem hiding this comment.
nit: I would rename it to say something like update_new_version_publication_date or something more specific to avoid confusion.
plus if possible, a small test as well?
Contributor
There was a problem hiding this comment.
plus one to this. Could you also add a test please?
0einstein0
force-pushed
the
flag-version-date
branch
from
5c26655 to
ed0564a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #387
Adding a config flag
update_new_version_publication_date, defaults toTrue.If set
False, the subsequent versions will have the same publication date for all versions.Migration template doc update: https://gitlab.cern.ch/cds-team/cds-rdm-openshift/-/merge_requests/24