removing soft quota and renmaing hard quota to id_quota#1836
Merged
Conversation
Collaborator
|
This looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove soft quota and rename registry hard_quota to id_quota.
Summary
Removes
soft_quotafrom registry organization surfaces and renames registryhard_quotatoid_quotaacross models, schemas, controllers, repositories, docs, migrations, and tests.Important Changes
src/model/cnaorg.js,src/model/adporg.js,src/model/secretariatorg.jssoft_quota.hard_quotatoid_quota.src/repositories/baseOrgRepository.jsid_quota.id_quota.src/controller/org.controller/index.js/registry/org/:shortname/hard_quotato/registry/org/:shortname/id_quota.schemas/registry-org/*.json,api-docs/openapi.jsonid_quota.soft_quotafrom registry org schema responses.src/scripts/migrate.jsid_quota.test/integration-tests/**,test/unit-tests/org/orgCreateTest.jsid_quota.soft_quotain registry org creation.Testing
Steps to manually test updated functionality, if possible
id_quotaand verify the response includesid_quota./api/registry/org/{shortname}/id_quotaand verify the response includesid_quota,total_reserved, andavailable.soft_quotaand verify the API returns 400.bash -i -c "npm run test:integration".