Skip to content

Resolves Issue #1848: partner_role_type array of enums#1849

Open
afoote-mitre wants to merge 1 commit into
devfrom
af-1848
Open

Resolves Issue #1848: partner_role_type array of enums#1849
afoote-mitre wants to merge 1 commit into
devfrom
af-1848

Conversation

@afoote-mitre

@afoote-mitre afoote-mitre commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Closes Issue #1848

Summary

Updates partner_role_type for registry organizations to be an array of allowed enum values instead of a scalar string.

Important Changes

schemas/registry-org/BaseOrg.json

  • Changed partnerRoleType to validate an array of enum values.

schemas/registry-org/create-registry-org-request.json

  • Updated create request validation for partner_role_type arrays.

schemas/registry-org/update-registry-org-request.json

  • Updated update request validation for partner_role_type arrays.

src/model/baseorg.js

  • Changed partner_role_type persistence from String to optional string array.

test/integration-tests/registry-org/registryOrgCRUDTest.js

  • Updated create, get, update, and invalid enum assertions for array-shaped partner_role_type.

src/scripts/test_data/testData.js

  • Updated registry seed helper data to send singleton arrays.

Testing

Steps to manually test updated functionality, if possible

  • 1) Run bash -i -c "npm run test:integration".
  • 2) Create a registry org with partner_role_type: ["Vendor"] and confirm it is returned as an array.
  • 3) Update a registry org with multiple values such as ["Researcher", "Vendor"] and confirm both persist.
  • 4) Try partner_role_type: ["Invalid Enum Value"] and confirm validation returns 400.

@afoote-mitre afoote-mitre requested a review from david-rocca June 10, 2026 18:33
@afoote-mitre afoote-mitre changed the title Allow partner_role_type arrays Resolves Issue #1848: partner_role_type array of enums Jun 10, 2026
@afoote-mitre afoote-mitre self-assigned this Jun 10, 2026
@jdalphond-mitre

Copy link
Copy Markdown
Collaborator

Looks good in theory. I will run my tests tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants