Resolves Issue #1848: partner_role_type array of enums#1849
Open
afoote-mitre wants to merge 1 commit into
Open
Resolves Issue #1848: partner_role_type array of enums#1849afoote-mitre wants to merge 1 commit into
afoote-mitre wants to merge 1 commit into
Conversation
Collaborator
|
Looks good in theory. I will run my tests tomorrow morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1848
Summary
Updates
partner_role_typefor registry organizations to be an array of allowed enum values instead of a scalar string.Important Changes
schemas/registry-org/BaseOrg.jsonpartnerRoleTypeto validate an array of enum values.schemas/registry-org/create-registry-org-request.jsonpartner_role_typearrays.schemas/registry-org/update-registry-org-request.jsonpartner_role_typearrays.src/model/baseorg.jspartner_role_typepersistence fromStringto optional string array.test/integration-tests/registry-org/registryOrgCRUDTest.jspartner_role_type.src/scripts/test_data/testData.jsTesting
Steps to manually test updated functionality, if possible
bash -i -c "npm run test:integration".partner_role_type: ["Vendor"]and confirm it is returned as an array.["Researcher", "Vendor"]and confirm both persist.partner_role_type: ["Invalid Enum Value"]and confirm validation returns400.