Resolves Issue # 1846: Org PUT response masking#1850
Open
afoote-mitre wants to merge 3 commits into
Open
Conversation
Collaborator
|
I think this is too restrictive. The response from the get still needs to have Those things exist in the schema. The point is to remove things that are NOT in the schema. |
Collaborator
Author
@david-rocca we will want to chat about this one further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1846
Summary
This MR masks stale registry org fields from GET responses so old document shapes do not get returned to clients, while preserving valid response fields and underscore-prefixed response extension fields.
Important Changes
src/repositories/baseOrgRepository.jsprogram_datapaths.created,last_updated,users,admins,reports_to, andconversation._relatedOrganizationswithout adding them to response schemas._id,__v, and__t.src/controller/registry-org.controller/registry-org.controller.jssrc/controller/registry-user.controller/registry-user.controller.jssrc/repositories/baseUserRepository.jstest/integration-tests/registry-org/registryOrgCRUDTest.js_relatedOrganizations, is preserved.Testing
Steps to manually test updated functionality, if possible
bash -i -c "npm run test:integration".