Skip to content

fix(store): storeReviews의 0 값 cursor 보존#160

Merged
chanwoo7 merged 1 commit into
developfrom
feat/store-review-cursor-fix
Jun 23, 2026
Merged

fix(store): storeReviews의 0 값 cursor 보존#160
chanwoo7 merged 1 commit into
developfrom
feat/store-review-cursor-fix

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

Summary

storeReviews의 cursor가 "0"일 때 페이지가 리셋되던 버그를 수정한다. 머지된 PR #159(storeReviews) 이후, PR #158(storeProducts) 리뷰에서 발견된 동일 패턴(0n falsy 누락)을 storeReviews에도 적용하는 후속이다.

Scope

  • listStoreReviews의 cursor 분기를 args.cursor ?args.cursor !== undefined로 변경
  • parseId("0") = 0n이 truthiness 체크에서 falsy로 떨어져 zero cursor가 필터를 드롭(=첫 페이지 재조회)하던 것을, 0n을 유효 인자로 다뤄 빈 결과(올바른 동작)가 되도록 수정

배경

Impact

  • 조회 동작 정정만(스키마/계약 변경 없음). 정상 cursor(실제 리뷰 id)는 동작 변화 없음

Test plan

  • cursor "0"은 페이지를 리셋하지 않고 빈 결과를 반환하는 테스트 추가
  • yarn validate 전체 통과(pre-push)

storeProducts(#158)와 동일하게 parseId("0")=0n이 args.cursor truthiness 체크에서 falsy로 떨어져 zero cursor가 페이지를 리셋하던 문제를 수정한다. listStoreReviews의 cursor 분기를 !== undefined로 바꾼다.
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d853952b-c9f7-40a1-998c-b23ade6a9fbe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/store-review-cursor-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 89/100 (Good)

진단 258건 (error 0).

Category error warning info
architecture 0 0 13
correctness 0 108 0
performance 0 24 16
schema 0 0 84
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.46% 3985/4089
🟢 Branches 93.24% 1242/1332
🟢 Functions 94.8% 748/789
🟢 Lines 97.87% 3635/3714

Test suite run success

1377 tests passing in 165 suites.

Report generated by 🧪jest coverage report action from a8fd88b

@chanwoo7 chanwoo7 merged commit 93882a4 into develop Jun 23, 2026
12 checks passed
@chanwoo7 chanwoo7 deleted the feat/store-review-cursor-fix branch June 23, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant