Skip to content

Reverted axis helpers z-layer change #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmwright merged 1 commit into from
Jul 3, 2026
Merged

Reverted axis helpers z-layer change #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cq_editor/widgets/object_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
from OCP.AIS import AIS_Line
from OCP.Geom import Geom_CartesianPoint
from OCP.gp import gp_Pnt
from OCP.Graphic3d import Graphic3d_ZLayerId_Topmost
from OCP.Bnd import Bnd_Box

from ..mixins import ComponentMixin
Expand Down Expand Up @@ -279,7 +278,6 @@ def addLines(self):
p1, p2 = self._axis_points(direction, DEFAULT_AXIS_HALF_LEN)
line = AIS_Line(p1, p2)
line.SetColor(to_occ_color(color))
line.SetZLayer(Graphic3d_ZLayerId_Topmost)

item = ObjectTreeItem(name, ais=line)
self.Helpers.addChild(item)
Expand Down
12 changes: 0 additions & 12 deletions cq_editor/widgets/viewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
Graphic3d_StereoMode,
Graphic3d_NOM_JADE,
Graphic3d_MaterialAspect,
Graphic3d_ZLayerId_Topmost,
)
from OCP.AIS import (
AIS_Shaded,
Expand Down Expand Up @@ -128,7 +127,6 @@ def __init__(self, parent=None):
)

self.setup_default_drawer()
self.setup_helper_layer()
self.updatePreferences()

def setup_default_drawer(self):
Expand All @@ -145,16 +143,6 @@ def setup_default_drawer(self):
line_aspect.SetWidth(DEFAULT_EDGE_WIDTH)
line_aspect.SetColor(DEFAULT_EDGE_COLOR)

def setup_helper_layer(self):
"""
Set up a render layer specifically for the axis helper lines.
"""
viewer = self.canvas.context.CurrentViewer()
settings = viewer.ZLayerSettings(Graphic3d_ZLayerId_Topmost)
settings.SetEnableDepthTest(False) # lines never depth-compare with the model
settings.SetEnableDepthWrite(False) # lines never write into the depth buffer
viewer.SetZLayerSettings(Graphic3d_ZLayerId_Topmost, settings)

def updatePreferences(self, *args):

color1 = to_occ_color(self.preferences["Background color"])
Expand Down
Loading