Skip to content

to_compound: return an empty compound for an empty list instead of raising (#600) #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youdie006 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

to_compound: return an empty compound for an empty list instead of raising (#600) #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cq_editor/cq_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ def to_compound(
vals.extend(obj.vals())
elif isinstance(obj, cq.Shape):
vals.append(obj)
elif isinstance(obj, list) and not obj:
pass # an empty list produces an empty compound (see #600)
elif isinstance(obj, list) and isinstance(obj[0], cq.Workplane):
for o in obj:
vals.extend(o.vals())
Expand Down
9 changes: 9 additions & 0 deletions tests/test_cq_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,12 @@ def test_to_compound_applies_sketch_placement():

assert f.Area() == pytest.approx(1)
assert f.normalAt().toTuple() == pytest.approx((0, -1, 0))


def test_to_compound_empty_list():
# #600: to_compound([]) used to raise IndexError while type-checking obj[0].
result = to_compound([])

assert isinstance(result, cq.Compound)
assert result.Solids() == []
assert result.Faces() == []
Loading