[WIP] Add list details page for managing include/exclude list values - #3264
Draft
zackcl wants to merge 1 commit into
Draft
[WIP] Add list details page for managing include/exclude list values#3264zackcl wants to merge 1 commit into
zackcl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3255
Summary
Implements the list details page design proposed in #3255.
Key behavior
Values (N)and omitted when the list is emptyIntentional differences from #3255
Based on implementation review and UX iteration:
Valuesrather thanValues (0)Large-list handling
The previous experiment query loaded inclusion and exclusion list members in the same joined result. Large lists could therefore produce a multiplicative number of database rows and exhaust the Node.js heap.
This WIP loads inclusion and exclusion segment data separately and merges the results by experiment ID, avoiding that Cartesian growth without requiring a database migration.
Tested with an experiment containing:
Current WIP scope
The details page is currently connected to private lists owned by experiments, feature flags, and segments. This PR is intended for UX and large-list testing before the implementation is finalized.
Screenshot
Screen recording
list.details.page.mov