[DEV] Tell the harness agent not to extend a non-deployable contract - #143
Merged
Conversation
The instruction to write "a minimal contract which simply extends the target" holds only when the target is deployable. Extending an abstract contract -- or one that leaves part of an inherited interface to a sibling that is mixed in further down the hierarchy -- produces a harness solc rejects, and even if it compiled the Prover would have no instance for it. Judging deployability also cannot be done from the target's own file: the unimplemented functions may be declared in an interface it inherits. Direct the agent to harness the concrete contract the protocol deploys in that case, and to fill in the missing functions itself only when the project has no concrete contract inheriting from the target. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of #130 onto the
devbleeding-edge branch.Source branch:
shelly/harness-prompt-abstract-targets. This branch is that head merged forward withdev; #130 itself is untouched and still targetsmaster.Per the
devbranch policy this merges without review oncepyrightandpytestare green.