-
Notifications
You must be signed in to change notification settings - Fork 4
feat(js): add typed array toArray #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,18 @@ pub fn TypedArray(comptime Element: type, comptime array_type: TypedarrayType) t | |
| return typed_ptr[0..info.length]; | ||
| } | ||
|
|
||
| /// Copies the TypedArray into a zig array of exactly `len` elements. | ||
| /// | ||
| /// Returns: | ||
| /// 1) `error.LengthMismatch` when the TypedArray length differs from | ||
| /// `len`, or | ||
| /// 2) `error.TypeMismatch` when its element type is wrong. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note, best for a separate PR: it would be nice to define the error sets for consumer use and use explicit error sets in return types. |
||
| pub fn toArray(self: Self, comptime len: usize) ![len]Element { | ||
| const slice = try self.toSlice(); | ||
| if (slice.len != len) return error.LengthMismatch; | ||
| return slice[0..len].*; | ||
| } | ||
|
|
||
| /// Creates a new JavaScript TypedArray backed by an *external* (native-heap) | ||
| /// ArrayBuffer. | ||
| /// | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this fn for? Did this get committed accidentally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it's just an example usage of
toArray(like the rest of the fn in this file)but honestly im not a fan of the entire
examples/dir to begin with but not sure of a better alternative at this timeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ChainSafe/zapi/pull/70/changes#diff-a24c69f7c57c058cefeeae13a7b33663ad8d99728877cb8e7d313cbca738a679R204-R210 runs these tests here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry, my sloppy review. I didn't see that this was an example.