Temp: Fix crash with AE2 GUIs#156
Merged
Merged
Conversation
Member
|
It doesnt seem to apply muis asm when stackup and ae2 are not installed |
Contributor
Author
|
Should apply the ASM correctly now without the other mods present. |
Member
|
Why are you not using my asm when ae2 is not installed? |
Contributor
Author
|
Functionally it'll be the same, but I'll make the temporary ASM apply only if AE2 is installed then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temporary fix for #154 by copying AE2/StackUp's logic for transforming stack sizes to
PacketUtil#writeItemStackFromClientToServer(). This PR should be reverted by #155 once the corresponding AE2 PR is merged.