Sync/release 0.10.0: Request Cancellation#2943
Open
chernser wants to merge 19 commits into
Open
Conversation
…us code to be more certain about codes
[v0.10.0-rc1] Request Cancellation
chernser
marked this pull request as ready for review
July 21, 2026 06:36
Contributor
Author
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fcdf02d. Configure here.
| } else { | ||
| req.setEntity(wrapRequestEntity(httpEntity, requestConfig)); | ||
| } | ||
| return new TransportRequestImpl(req, requestConfig); |
There was a problem hiding this comment.
Multipart client compression not disabled
Medium Severity
Refactoring createRequest removed the prior step that set COMPRESS_CLIENT_REQUEST to false for multipart (statement params in body) requests. Multipart bodies are attached without wrapRequestEntity, but addHeaders can still set Content-Encoding when HTTP/client compression is enabled, so the server may receive uncompressed multipart data advertised as compressed.
Reviewed by Cursor Bugbot for commit fcdf02d. Configure here.
Contributor
Author
There was a problem hiding this comment.
This is fine. We have reviewed it in PR. This is to avoid mutation of request config.
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
changed the title
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary