fix(medcat-trainer): Fix Try Model bug after medcat V2#531
Merged
Conversation
tomolopolis
approved these changes
Jun 10, 2026
tomolopolis
left a comment
Member
There was a problem hiding this comment.
lgtm - nice thanks for picking up this fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the try model page
500 Error on /api/annotate-text/
Error introduced in this PR
https://github.com/CogStack/cogstack-nlp/pull/309/changes
No entities returned
Original code then seems to be dependent on each Entity being loaded in already, but it really doesnt have to.
I'm not sure when the Entity table is meant to get loaded, so this is technically a work around, but really it's just simplifying it.
Current flow:
New flow