fix(medcat-trainer): Fix Spaces in model pack names breaking CDB import#533
Merged
alhendrickson merged 4 commits intoJun 11, 2026
Merged
Conversation
… CDB import - cleanup
… CDB import - cleanup
… CDB import - cleanup
tomolopolis
approved these changes
Jun 11, 2026
tomolopolis
left a comment
Member
There was a problem hiding this comment.
lgtm - makes sense. This used to make more sense when model upload was all done via humans that could rename the model name...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOLR can't have spaces in its collection name
Right now any model pack i save with a space in the name can never get imported.
Seems like it's always been like this, but anyway, hopefully this explains some of the inconsistencies with the import I'd been seeing.
Current behavior
The background process logs show this error:
New behavior
Just replace any chars that aren't allowed with underscores.
I think this is backwards compatible - anything on previous versions that was valid chars shouldnt get touched. & anything on previous versions that wasnt compatible wouldn't have been able to create a solr collection.