Skip to content

test(medcat-trainer): Fix the Concept view test broken in PR 532 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alhendrickson merged 1 commit into from
Jun 11, 2026
Merged

test(medcat-trainer): Fix the Concept view test broken in PR 532 #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions medcat-trainer/webapp/api/api/tests/test_views_concepts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,37 @@ def __init__(self, pt2ch=None, ch2pt=None, cui2info=None):
self.addl_info['ch2pt'] = ch2pt
self.cui2info = cui2info or {}

def get_name(self, cui):
return self.cui2info.get(cui, {}).get('preferred_name', cui)


@override_settings(MEDIA_ROOT='/tmp/mct-tests-concepts')
class CdbCuiChildrenTests(TestCase):
def setUp(self):
self.user = create_user(username='cui-children')
self.client = _auth_client(self.user)

def test_returns_400_when_cdb_has_no_pt2ch(self):
def test_returns_flat_root_when_cdb_has_no_pt2ch(self):
cdb = FakeCDB()
with patch('api.views.get_cached_cdb', return_value=cdb):
resp = self.client.get('/api/model-concept-children/1/')
self.assertEqual(resp.status_code, 400)
self.assertEqual(resp.status_code, 200)
self.assertEqual(resp.json()['results'], [
{'cui': 'Root', 'pretty_name': 'All concepts'},
])

def test_returns_flat_cdb_concepts_when_cdb_has_no_pt2ch(self):
cdb = FakeCDB(cui2info={
'C2': {'preferred_name': 'Concept Two'},
'C1': {'preferred_name': 'Concept One'},
})
with patch('api.views.get_cached_cdb', return_value=cdb):
resp = self.client.get('/api/model-concept-children/1/?parent_cui=Root')
self.assertEqual(resp.status_code, 200)
self.assertEqual(resp.json()['results'], [
{'cui': 'C1', 'pretty_name': 'Concept One'},
{'cui': 'C2', 'pretty_name': 'Concept Two'},
])

def test_returns_root_term_when_no_parent_cui(self):
cdb = FakeCDB(
Expand Down Expand Up @@ -108,6 +127,20 @@ def test_reuses_existing_ch2pt(self):
self.assertEqual(resp.status_code, 200)
mock_ch2pt.assert_not_called()

def test_returns_flat_path_when_cdb_has_no_pt2ch(self):
cdb = FakeCDB(cui2info={'C1': {'preferred_name': 'Concept One'}})
with patch('api.views.get_cached_cdb', return_value=cdb):
resp = self.client.get('/api/concept-path/?cdb_id=1&cui=C1')
self.assertEqual(resp.status_code, 200)
self.assertEqual(resp.json()['results'], {
'node_path': {
'cui': 'Root',
'pretty_name': 'All concepts',
'children': [{'cui': 'C1', 'pretty_name': 'Concept One'}],
},
'links': [{'parent': 'Root', 'child': 'C1'}],
})


@override_settings(MEDIA_ROOT='/tmp/mct-tests-concepts')
class GenerateConceptFilterFlatJsonTests(TestCase):
Expand Down
Loading