Skip to content

Fix faint lightshafts when Voxy/Distant Horizons is enabled #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aLink536 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

Fix faint lightshafts when Voxy/Distant Horizons is enabled #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions shaders/lib/atmospherics/volumetricLight/volumetricLight.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@ vec4 GetVolumetricLight(inout float vlFactor, vec3 translucentMult, float lViewP

float maxDistance = far * 0.98; // The distance where the fog is 1.0 and we stop tracing
float qualityThreshold = min(far, shadowDistance) * 0.98; // Only use farSamples from this point on to hit our maxDistance. Set higher than maxDistance to disable far samples

#if defined VOXY || defined DISTANT_HORIZONS
maxDistance = renderDistance * 0.5; // Covers lod chunks
// loddedMaxDistance is only used for sky pixels — non-sky pixels keep maxDistance = far
// so weight normalization isn't diluted by a large LOD render distance
float loddedMaxDistance = max(renderDistance * 0.5, maxDistance);

fogCurve = 0.7;
fogCurveIntense *= 1.0 - 0.5 * rainFactor;
Expand Down Expand Up @@ -142,7 +144,11 @@ vec4 GetVolumetricLight(inout float vlFactor, vec3 translucentMult, float lViewP

vec3 nViewPosInSceneSpace = normalize(mat3(gbufferModelViewInverse) * nViewPos);
vec3 rayDirection = nViewPosInSceneSpace;
float rayEnd = !sky ? min(lViewPos1, maxDistance) : maxDistance;
float rayEnd = !sky ? min(lViewPos1, maxDistance) : maxDistance;
#if defined VOXY || defined DISTANT_HORIZONS
// Sky pixels trace into LOD chunks; update maxDistance so weights normalize correctly
if (sky) { rayEnd = loddedMaxDistance; maxDistance = loddedMaxDistance; }
#endif
float lastDistance = 0.0;

#if defined END && !defined VOXY && !defined DISTANT_HORIZONS
Expand Down