ci: fix PR triggers (master → develop/main)#68
Merged
Conversation
Both ci-build.yml (PR check) and cd-build.yml (coverage/docs deploy) targeted a 'master' branch that doesn't exist — the project uses develop as integration branch and main for releases. PRs to develop (e.g. #65) have been landing with zero CI. Retargeted both to develop + main to match the actual branch topology. Co-Authored-By: Claude on behalf of Cail <noreply@anthropic.com>
CI (ci-build.yml): checkout@v4 + setup-python@v5, pip install '.[test]', plain pytest on ubuntu/macos x py3.10/3.12; also runs on pushes to develop/main. Drops conda-era plumbing (poetry, 'setup.py test', the miniconda PATH export), the hard-deprecated upload/download-artifact@v2 pair, the EnricoMi test-results job (its artifact name never matched, so it has been broken since inception), the pinned-2020 wemake-styleguide action, and codecov (badge points at a stale personal fork; no codecov.yml; codecov-action@v1 is dead). CD (cd-build.yml): now purely the docs pipeline — sphinx-apidoc + sphinx-build on a plain pip install '.[docs]', built as a check on PRs (HTML uploaded as artifact for preview) and deployed to gh-pages on pushes to develop/main via actions-gh-pages@v4. Conda setup, the duplicate test/coverage job, and the twine sdist check (publish.yml owns packaging) are gone; pandoc is not needed (no notebook sources). Docs deps move from docs/requirements.txt (sphinx 3.3.1-era pins that no longer install on py>=3.10) to a 'docs' extra in pyproject.toml; conf.py gains py3-native importlib.metadata and an Author-email fallback (modern packaging leaves 'Author' unset). Docs build verified locally on 3.12. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
ci-build.yml(PR check) andcd-build.yml(coverage/docs deploy on push) targeted amasterbranch that does not exist — the project usesdevelopas its integration branch andmainfor releases. As a result, PRs todevelop(e.g. #65, merged last night) landed with zero CI checks running. This retargets both workflows todevelopandmain, matching the branch topology that was already exercised by the v0.2.1 release cycle.— Claude on behalf of Cail