Skip to content

fuse: don't leak AOP_TRUNCATED_PAGE from fuse_write_begin() #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbirth merged 1 commit into from
Jun 11, 2026
Merged

fuse: don't leak AOP_TRUNCATED_PAGE from fuse_write_begin() #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion fs/fuse/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,10 +2252,12 @@ static int fuse_write_begin(struct file *file, struct address_space *mapping,
struct fuse_conn *fc = get_fuse_conn(file_inode(file));
struct page *page;
loff_t fsize;
int err = -ENOMEM;
int err;

WARN_ON(!fc->writeback_cache);

retry:
err = -ENOMEM;
page = grab_cache_page_write_begin(mapping, index);
if (!page)
goto error;
Expand Down Expand Up @@ -2285,6 +2287,13 @@ static int fuse_write_begin(struct file *file, struct address_space *mapping,
cleanup:
unlock_page(page);
put_page(page);
/*
* ->write_begin has no AOP_TRUNCATED_PAGE contract; a positive
* return would pass the "status < 0" check in
* generic_perform_write() and crash on an unset *pagep.
*/
if (err == AOP_TRUNCATED_PAGE)
goto retry;
error:
return err;
}
Expand Down
Loading