Improve SystemMessage styling and dismissal#902
Open
haavamoa wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds dedicated
SystemMessageStylesupport so system messages can use Alert-based background, text, and border color roles without changing the existing Alert styles.This also updates
SystemMessagewith border and shadow, icon color that follows the text color by default, screen reader announcement asSystem melding: <message>, and a vertical fling-to-dismiss interaction. Component and Playground samples were updated to cover the new styles and readonly/normal-mode examples.Documentation and changelog entries are included for the public API and behavior changes.
Todos