Add optional OpenNIC root support (OPENNIC=1)#125
Merged
Conversation
Contributor
Author
|
@jedisct1 any interest in this PR? |
Member
|
Looks really good, thanks! One small thing: in the original script, But with the change, the chain stops at the chown, so the anchor setup now runs even if creating the directory failed. Ok, this is probably harmless in practice, but I'd prefer to keep the old guarantee :) |
Contributor
Author
|
Good catch, fixed. The anchor setup (both modes) is now the third link of the mkdir/chown chain again, and the OpenNIC branch also gates its chown on the cp succeeding. I also tested this in my infra, the new code is up and resolving. =) |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
OPENNIC=1on the container makes Unbound resolve from the OpenNICroot instead of the ICANN root. Without the variable, nothing changes.
In OpenNIC mode, the generated config uses
root-hints: "opennic.hints"andauto-trust-anchor-file: "var/opennic.key"(seeded from the baked-in OpenNICKSK, then maintained via RFC 5011). The internic auth-zone and the
unbound-anchorcall are skipped. The OpenNIC root carries the DS records ofthe ICANN TLDs, so validation of the regular namespace is unaffected.
entrypoint.shchange:/etc/runit/2execsenv -, so service scripts neversee container env vars.
start()writes the value to/etc/opennic-envandunbound.shreads it as a fallback.The hints and KSK (key tag 60820) were fetched from two independent OpenNIC
servers over DoH and match the anchor published on the OpenNIC wiki. Refresh
instructions are in the README.
Tested:
unbound-checkconfclean in both modes, default-mode configunchanged. Deployed live behind dnscrypt-proxy:
grep.geekresolves, andcom. SOAreturns theadflag through the OpenNIC anchor.Let me know if there is anything you want me to adjust or improve. =)