-
-
Notifications
You must be signed in to change notification settings - Fork 362
[seongmin36] WEEK 03 Solutions #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seongmin36
wants to merge
2
commits into
DaleStudy:main
Choose a base branch
from
seongmin36:week3-solutions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| toString(2)으로 해결했다가 다른 분의 풀이를 보고 다시 풀어보았다. | ||
|
|
||
| '비트 연산을 통한 계산'이다. | ||
| 컴퓨터에서 모든 언어는 2진법으로 변환이 되는데, 이를 이용한 플이다. | ||
| 가장 오른쪽 비트가 1인 경우에 count++, n을 우측으로 1칸 shift. | ||
| shift를 하면 결국 남는 숫자는 0이기 때문에 적절한 조건으로 루프를 빠져나온다. | ||
|
|
||
| 굳이 2진법으로 변환하지 않고도 계산할 수 있어서 이게 더 좋은 풀이라 생각하였다. | ||
| */ | ||
| /** | ||
| * @param {number} n | ||
| * @return {number} | ||
| */ | ||
| function hammingWeight(n) { | ||
| let count = 0; | ||
|
|
||
| while (n !== 0) { | ||
| count += n & 1; | ||
| n >>>= 1; | ||
| } | ||
|
|
||
| return count; | ||
| } |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🏷️ 알고리즘 패턴 분석
📊 시간/공간 복잡도 분석
피드백: 전처리로 문자열을 단일 문자열로 정규화하고 양끝에서 양방향 탐색으로 팔린드롬 여부를 판단한다. 개선 제안: 현재 구현이 적절해 보입니다.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /** | ||
| s를 정규식으로 알파벳 소문자 string만 남겨둬야한다. | ||
| 알파벳 소문자만 남겨놓도록 하는 정규식은 '/[^a-z0-9]/gi'이다. | ||
| left(0)와 right(마지막 인덱스)를 동시에 하나씩 줄여가면서 비교 | ||
| */ | ||
|
|
||
| /** | ||
| * @param {string} s | ||
| * @return {boolean} | ||
| */ | ||
| function isPalindrome(s) { | ||
| s = s.replace(/[^a-z0-9]/gi, "").toLowerCase(); | ||
|
|
||
| let left = 0; | ||
| let right = s.length - 1; | ||
|
|
||
| while (left < right) { | ||
| if (s[left] !== s[right]) { | ||
| return false; | ||
| } | ||
|
|
||
| left++; | ||
| right--; | ||
| } | ||
|
|
||
| return true; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏷️ 알고리즘 패턴 분석
📊 시간/공간 복잡도 분석
피드백: 각 반복마다 최하위 비트를 확인하고 오른쪽으로 시프트하여 남은 비트를 처리한다. 입력 n의 비트 길이에 비례하는 시간 복잡도를 가진다.
개선 제안: 현재 구현이 적절해 보입니다.