✨ [FFL-2858] Feature Flags tab — catalog browsing (stacked PR 2 of 3) - #4916
Open
kellyw1806 wants to merge 1 commit into
Open
✨ [FFL-2858] Feature Flags tab — catalog browsing (stacked PR 2 of 3)#4916kellyw1806 wants to merge 1 commit into
kellyw1806 wants to merge 1 commit into
Conversation
This was referenced Jul 27, 2026
Bundles Sizes Evolution
|
|
greghuels
reviewed
Jul 27, 2026
greghuels
reviewed
Jul 27, 2026
greghuels
reviewed
Jul 27, 2026
greghuels
reviewed
Jul 27, 2026
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
3 times, most recently
from
July 27, 2026 19:19
84c903a to
ba2f761
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 27, 2026 19:28
4d4f152 to
415b54b
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 27, 2026 19:28
ba2f761 to
5683248
Compare
kellyw1806
marked this pull request as ready for review
July 27, 2026 20:07
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 27, 2026 20:30
415b54b to
4a0a996
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 27, 2026 20:30
5683248 to
4af8227
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 27, 2026 20:40
4a0a996 to
de6b4ea
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 27, 2026 20:40
4af8227 to
7376fbf
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 27, 2026 20:54
de6b4ea to
9b5a9f3
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 27, 2026 20:54
7376fbf to
fb4faa6
Compare
Contributor
|
@kellyw1806 In my opinion I would keep the stacked PR 2 and 3 in draft until the first one is approved. That way after changes are requested in the first one, this one remains clean for the reviewer. |
kellyw1806
marked this pull request as draft
July 28, 2026 13:39
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 15:32
9b5a9f3 to
6d5a341
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 28, 2026 15:32
fb4faa6 to
230ae07
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 16:29
6d5a341 to
4596d8b
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 28, 2026 16:29
230ae07 to
673a2b1
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 17:19
4596d8b to
a2d74a1
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 28, 2026 17:19
673a2b1 to
2f033a5
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 17:39
a2d74a1 to
59a5aa6
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 28, 2026 17:39
2f033a5 to
98058ac
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 18:46
59a5aa6 to
dbf0fe9
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
2 times, most recently
from
July 28, 2026 20:01
e55866f to
322814a
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 28, 2026 21:30
dbf0fe9 to
cf550d4
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 28, 2026 21:30
322814a to
87a1c1a
Compare
Builds on FFL-2597: fetches the flag catalog via the OAuth-capable FFE UI endpoint (transparently refreshing the token), and renders it with search + type/tag filters and pagination. Read-only; overriding flags comes in FFL-2596.
kellyw1806
force-pushed
the
kelly.wang/ffl-2597
branch
from
July 29, 2026 15:32
cf550d4 to
3414896
Compare
kellyw1806
force-pushed
the
kelly.wang/ffl-2858
branch
from
July 29, 2026 15:32
87a1c1a to
875de0b
Compare
kellyw1806
marked this pull request as ready for review
July 29, 2026 15:46
kellyw1806
requested review from
BeltranBulbarellaDD and
Copilot
and removed request for
Copilot
July 29, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #4913 (OAuth). With the sign in functionality, this PR helps include the fetch for the total feature-flag catalog. Users are now able to browse their feature-flag catalog. It does not involve overriding flags as that is the next PR (#4912).
Stack (review bottom-up)
mainffl-2597ffl-2858Changes
GET /api/ui/ffe/feature-flagsendpoint (paginated), transparently refreshing the token (getValidAccessToken, added here).Demo
This is what the three PRs look like working together:
Screen.Recording.2026-07-24.at.5.14.31.PM.mov
Checklist
oauth.spec.ts—getValidAccessToken;flagCatalog.spec.ts).