Skip to content

fix: activate venv in publish_pypi.sh#842

Merged
joeyzhao2018 merged 1 commit into
mainfrom
joey/fix-pypi-release-script
Jul 13, 2026
Merged

fix: activate venv in publish_pypi.sh#842
joeyzhao2018 merged 1 commit into
mainfrom
joey/fix-pypi-release-script

Conversation

@joeyzhao2018

@joeyzhao2018 joeyzhao2018 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix poetry: command not found error in the publish-pypi-package CI job
  • The before_script runs setup_python_env.sh which installs poetry inside a virtualenv, but since it executes as a subshell the venv activation doesn't persist into the script: phase
  • Add source venv/bin/activate before calling poetry, matching the pattern used by the lint and unit-test jobs

@joeyzhao2018 joeyzhao2018 requested review from a team as code owners July 13, 2026 17:17
@joeyzhao2018 joeyzhao2018 changed the title fix publish_pypi.sh fix: activate venv in publish_pypi.sh Jul 13, 2026
@datadog-official

This comment has been minimized.

@joeyzhao2018 joeyzhao2018 merged commit d571d76 into main Jul 13, 2026
104 checks passed
@joeyzhao2018 joeyzhao2018 deleted the joey/fix-pypi-release-script branch July 13, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants