fix(tests/library_conf): fix payload normalization issue#7319
Closed
MilanGarnier wants to merge 2 commits into
Closed
fix(tests/library_conf): fix payload normalization issue#7319MilanGarnier wants to merge 2 commits into
MilanGarnier wants to merge 2 commits into
Conversation
Contributor
|
|
|
…race payload format _get_span_link_trace_id assumed link["traceID"] was always a hex string under the efficient format, but decoded native span links already provide it as an int, causing TypeError: int() can't convert non-string with explicit base.
cbeauchesne
reviewed
Jul 17, 2026
Contributor
Author
|
Oh thanks, this seems to completely fix my issue ! I'm closing this then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Node.js dev extraction-behavior end-to-end tests already emit the expected span link, but the test helper fails while normalizing
_dd.span_links. The v1 payload parser has already decoded that metadata into a list, and the helper attempts to decode it a second time.Changes
_dd.span_linksmetadata in extraction-behavior assertions../format.sh; the untouched YAML checks could not start because this fresh macOS worktree lackssha256sumfor theyamlfmtbootstrap. Focused pytest collection passed:venv/bin/pytest --collect-only -q tests/test_library_conf.py::Test_ExtractBehavior_Default::test_multiple_tracecontexts.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present