debugger: snapshot correlation tests#7330
Draft
grantseltzer wants to merge 2 commits into
Draft
Conversation
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Live Debugger lets an engineer drop logpoints into running code and see snapshots of what happened. Those snapshots are supposed to tell a complete story of a request from start to finish, but today the related snapshots often arrive in pieces, with no signal that anything is missing. There is now an approved plan for how every language's tracer should behave so the story stays whole, but there was no automated way to say whether each language actually follows it.
This adds that check, so we can track, per language, who meets the standard and who does not yet.
Changes
Adds end-to-end tests that hold each language's tracer to the agreed snapshot-correlation standard:
The tests run for all six languages (Go, Java, .NET, Node, Python, Ruby). Because no tracer has built this behavior yet, every language is currently marked "not yet implemented," so the tests run without failing the build and will turn green automatically once a language implements the standard. The change also adds the test endpoints to each language's sample app, Go included.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present