Update/tour#532
Open
jaayzee wants to merge 6 commits into
Open
Conversation
…t auto skipping forward/backward system. looks cooler too. segmented the tour into pages based, so they can specify which tour they want to see by the button on the top bar. changed from an id system to data-tour-id so we don't have repeat ids for accessibility. styled the tour system better to be smoother, will need to move this to dwd as well. implemented auto skipping for when elements with the data-tour-id disappear/ dont exist. probably more changes, but i forgot to commit earlier.
…button states to have no prev and next be finish at start and end.
…nted a isLoading state to the toursegments so they don't skip over tour steps on accident
…ttached loading states to tour to use. removed unsued tour functions, made autoskipping prev and next more robust to handle disappearing elements and loading elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Quick Checklist