fix(api): restore tier on paid subscription renewal - #116
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
A subscriber whose invoice temporarily failed was downgraded to the free tier by
invoice.payment_failed. If Stripe later collected the renewal invoice,invoice.paidgranted credits but did not restore the paid tier, leaving a paying customer stuck on free-tier limits.Root cause
The renewal webhook only incremented credits. It did not apply
tierFromSubscriptionPlanId(subscription.metadata.plan_id)the way the initial subscription checkout path does.Fix
Add a focused helper for paid subscription invoice updates and use it in the renewal transaction so recognized plan metadata restores the paid tier while malformed metadata does not accidentally downgrade an existing tier.
Validation
npm run buildnode tests/billing-helpers.test.mjsnpx tsc --noEmit