Sharing state between active windows#975
Open
filipslezaklab wants to merge 4 commits into
Open
Conversation
filipslezaklab
commented
Jun 17, 2026
filipslezaklab
commented
Contributor
- ui fixes
wojcik91
reviewed
Jun 17, 2026
|
|
||
| listen<AddInstanceEventPayload>(TauriEvent.AddInstance, (event) => { | ||
| console.log('[TauriEvent] AddInstance (instances invalidation)', event.payload); | ||
| void debug(`UI Received event AddInstance: ${JSON.stringify(event.payload)}`); |
Contributor
There was a problem hiding this comment.
This logs the refresh token on disk which should be avoided
| const unlisteners = Promise.all([ | ||
| listen<AddInstanceEventPayload>(TauriEvent.AddInstance, (event) => { | ||
| console.log('[TauriEvent] AddInstance', event.payload); | ||
| void debug(`UI Received event AddInstance: ${JSON.stringify(event.payload)}`); |
Contributor
There was a problem hiding this comment.
This logs the refresh token on disk which should be avoided
| const current = sessionState?.location_mfa_preference ?? {}; | ||
| api | ||
| .patchSessionState({ | ||
| location_mfa_preference: { ...current, [String(locationId)]: method }, |
Contributor
There was a problem hiding this comment.
Consider a backend command to update the method for a specific location instead of replacing the whole map.
| setLocationMfaPreference(location.id, selectedMethod); | ||
| if (setAsDefault && selectedMethod !== locationDefaultMfaMethod && location) { | ||
| setMfaMethod({ locationId: location.id, mfaMethod: selectedMethod }); | ||
| } else { |
| pub async fn patch_session_state( | ||
| patch: SessionStatePatch, | ||
| app_handle: AppHandle, | ||
| ) -> Result<SessionState, ()> { |
Contributor
There was a problem hiding this comment.
Drop the Result if we don't actually ever return an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.