Skip to content

Deprecate mode and provider inputs#50

Merged
lionello merged 4 commits into
mainfrom
lionello-patch-1
Jul 10, 2026
Merged

Deprecate mode and provider inputs#50
lionello merged 4 commits into
mainfrom
lionello-patch-1

Conversation

@lionello

@lionello lionello commented Jul 10, 2026

Copy link
Copy Markdown
Member

Mark 'mode' and 'provider' as deprecated in favor of 'stack'.

Summary by CodeRabbit

  • Documentation

    • Marked the mode and provider inputs as deprecated in favor of stack.
    • Updated documented provider options and refreshed workflow examples to include the deprecation notes and new example values.
  • Tests

    • Updated workflow scenarios to stop supplying the deprecated mode input during compose command runs, keeping other inputs unchanged.

lionello added 3 commits July 10, 2026 15:24
Mark 'mode' and 'provider' as deprecated in favor of 'stack'.
Updated descriptions for 'mode' and 'provider' fields to indicate deprecation in favor of 'stack'.
Removed 'mode' setting from two steps in the workflow.
@lionello lionello requested a review from a team as a code owner July 10, 2026 22:28
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a31cc8ee-5f41-4071-a5f9-d5b409927ad8

📥 Commits

Reviewing files that changed from the base of the PR and between abf1116 and c41726f.

📒 Files selected for processing (1)
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

📝 Walkthrough

Walkthrough

The action marks mode and provider as deprecated in favor of stack, updates provider documentation, annotates the README example, and removes mode from two test workflow invocations.

Changes

Legacy input deprecation

Layer / File(s) Summary
Deprecation metadata and documentation
action.yaml, README.md
Input descriptions and the full workflow example mark mode and provider as deprecated in favor of stack; documented provider options no longer include defang.
Workflow mode removal
.github/workflows/test.yaml
Two local action invocations no longer pass mode, while their commands and remaining inputs stay unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: deprecating the mode and provider inputs in favor of stack.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lionello-patch-1

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@action.yaml`:
- Line 38: The deprecated mode documentation and canonical README example are
inconsistent. Update the README’s canonical deployment example to remove the
deprecated mode: "staging" input and demonstrate stack alone, or revise
action.yaml’s accepted values to include staging if it remains supported.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dce29a2b-5daf-40d1-8dce-eb3c153812d8

📥 Commits

Reviewing files that changed from the base of the PR and between 2202660 and abf1116.

📒 Files selected for processing (3)
  • .github/workflows/test.yaml
  • README.md
  • action.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/test.yaml

Comment thread action.yaml
Updated deployment configuration to use 'balanced' mode and removed deprecated 'staging' mode.
@lionello lionello merged commit 310e286 into main Jul 10, 2026
4 of 5 checks passed
@lionello lionello deleted the lionello-patch-1 branch July 10, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant