fix(client): correct binding and error macro in SendInitiateFileCopy arm#1390
Merged
Richard Markiewicz (thenextman) merged 1 commit intoJun 30, 2026
Conversation
The ClipboardMessage::SendInitiateFileCopy arm in the clipboard event handler refers to a cliprdr binding and a session::custom_err! macro that are not in scope. The surrounding handler binds the processor as cliprdr_client, and every other arm uses ironrdp_session::custom_err!. With the clipboard feature enabled this fails to compile (E0425 for cliprdr, E0433 for session), so master does not build. Align the arm with its siblings. Verified with cargo check -p ironrdp-client --features rustls,clipboard.
Richard Markiewicz (thenextman)
approved these changes
Jun 30, 2026
Richard Markiewicz (thenextman)
merged commit b407c6f
into
Devolutions:master
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ClipboardMessage::SendInitiateFileCopyarm in the clipboard event handler refers to acliprdrbinding and asession::custom_err!macro that are not in scope. The surrounding handler binds the processor ascliprdr_client, and every other arm in the same match usesironrdp_session::custom_err!. With theclipboardfeature enabled this fails to compile:so master does not build with the clipboard feature on. This aligns the arm with its siblings.
Verified with
cargo check -p ironrdp-client --features rustls,clipboard.