Added new move on click plan#1637
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 164 164
Lines 8989 8997 +8
=======================================
+ Hits 8367 8375 +8
Misses 622 622
🚀 New features to boost your workflow:
|
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, a couple of things to do...
I think we may need to run this on the beamline to be totally sure it does the same as the old one
069450e to
83199cc
Compare
9074afc to
80c0b04
Compare
| def test_move_on_oav_view_click( | ||
| coordinates, expected_x, expected_y, oav, pmac, run_engine | ||
| ): | ||
| def fake_rd(_signal): |
There was a problem hiding this comment.
Would be nice to parametrize here on a couple of different values of microns per pixel x/y just to ensure that the calculation does actually use them correctly
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Looks good, only one minor comment, take it or leave it
f7817ee to
6df88a3
Compare
| run_engine, | ||
| ): | ||
| def fake_rd(_signal): | ||
| if _signal == oav.microns_per_pixel_x: |
There was a problem hiding this comment.
should really be _signal is oav.microns_per_pixel_x
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Approved, one small additional comment
3 participants
Fixes DiamondLightSource/mx-daq-ui#86
Instructions to reviewer on how to test:
Checks for reviewer