ENG-1800 Create relation dialog closes when there is no match

[maparent]

https://linear.app/discourse-graphs/issue/ENG-1800/create-relation-dialog-closes-when-there-is-no-match

Revised loom:
https://www.loom.com/share/e915bcae39f5473f8cf3bacf73de3ebd

---

[linear-code]

ENG-1800

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

[mdroidian]

Just quickly looked at the code/video and changing the type of setResult to accept string doesn't seem right.

We use a similar pattern Result with the AutocompleteInput component in multiple places in the repo, is this the same pattern we use in those places (eg Canvas, Share via, Query Builder, etc)? Do those place also experience this same problem?

[mdroidian]

I would prefer if we stick to using Result, but this works as well I guess.

Also see graphite's comment.

[maparent]

re using Result: Then we'd have to either modify AutoCompleteInput so it filters strings outside choices through a function that transforms strings into Results, or use my previous solution.