Skip to content

Update rules for logical/control variables#152

Open
mkavulich wants to merge 2 commits into
ESCOMP:mainfrom
mkavulich:rules_for_logicals
Open

Update rules for logical/control variables#152
mkavulich wants to merge 2 commits into
ESCOMP:mainfrom
mkavulich:rules_for_logicals

Conversation

@mkavulich

@mkavulich mkavulich commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Update the rules for logical and control variables to distinguish what prefixes are allowed and when they should be used, based on the proposal in Issue #101. Also update a few standard names based on these rules.

This PR would supersede #149

Issues

Resolves #101

@mkavulich mkavulich changed the title Update rules for logical/control variables based on proposal in issue #101 Update rules for logical/control variables Jul 2, 2026
@mkavulich

Copy link
Copy Markdown
Collaborator Author

@nusbaume When you get a chance, can you look at this and see if it's a good substitute for your #149?

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this. There is always going to be some ambiguity what to use, but hopefully the rules PLUS existing names in the dictionary will help.

@nusbaume

nusbaume commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR @mkavulich! I'm happy with this replacing my previous PR.

With regards to the standard names, was there a reason why flag_for_ was chosen over is_? I personally find is_ to be clearer, especially when do_ is also allowed (as one is for a given state or condition, while the other is to indicate a specific action, and both make it clear as to what a .true. value means). However I could certainly be convinced otherwise if people have reasons they prefer flag_for_. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[release/v1] Rules for "flag", "index", and other similar control variables

3 participants