Add additional attributes to cylindrical cache file#225
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the HDF5 cylindrical cache metadata written by EmpCylSL to include additional construction/provenance parameters (PCA/EOF toggles, spherical-grid and smoothing parameters, and EOF quadrature sizes), and bumps the project/documentation version to 7.11.1.
Changes:
- Persist additional
EmpCylSLconfiguration/state as HDF5 attributes inWriteH5Cache(). - Track and record EOF quadrature parameters (
eof_numr/eof_nump/eof_numt) for provenance. - Bump EXP version strings in CMake and Doxygen config files.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/EmpCylSL.H | Adds storage for EOF quadrature provenance parameters. |
| exputil/EmpCylSL.cc | Saves EOF quadrature sizes and writes new provenance attributes into the HDF5 cache. |
| doc/exp.cfg.breathe | Bumps generated documentation version to 7.11.1. |
| doc/exp.cfg | Bumps generated documentation version to 7.11.1. |
| CMakeLists.txt | Bumps project version to 7.11.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Everything seems to work as intended! |
CarrieFilion
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Add all parameters that uniquely identify the state on construction for future reproduction and provenance.
Added parameters include:
file.createAttribute ("enforce_limits", HighFive::DataSpace::From(enforce_limits)).write(enforce_limits);
Notes
These changes are non invasive and can not break older versions of EXP.
Tests
Basis