Skip to content

Clarify npm (not yarn) usage in README setup#6019

Closed
j0ntz wants to merge 2 commits into
developfrom
agent/1215342253893506
Closed

Clarify npm (not yarn) usage in README setup#6019
j0ntz wants to merge 2 commits into
developfrom
agent/1215342253893506

Conversation

@j0ntz
Copy link
Copy Markdown
Contributor

@j0ntz j0ntz commented Jun 2, 2026

Description

Asana task

Docs-only change for an end-to-end agent-pipeline smoke test (Asana task).

Adds a short clarifying sentence to the README "Getting Started" section noting that the project previously used yarn but has since migrated to npm, so contributors should use the npm commands rather than yarn.

The original task was drafted before the yarn→npm migration and literally asked for a "uses yarn (not npm)" note. Since the repo now uses npm (yarn.lock removed, package-lock.json present, README commands all use npm), that literal note would be inaccurate. The accurate, value-adding version is committed instead.

Note: this branch is based on a worktree that has the (not-yet-on-develop) "Convert package manager from yarn to npm" commit cherry-picked in for tooling. The only commit that is this task's work is the single README change (Clarify npm (not yarn) usage in README setup); the npm-migration diff will disappear from this PR once that change lands on develop.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

No GUI changes — documentation only.


Note

Low Risk
Changes are limited to install/CI configuration and documentation; no auth, payment, or app runtime logic is modified.

Overview
This PR standardizes the repo on npm instead of Yarn for installs, scripts, and CI.

Configuration: .npmrc gains ignore-scripts=true and legacy-peer-deps=true (behavior previously in .yarnrc, which is removed). package.json already pins packageManager to npm.

CI / automation: Travis and the Jenkinsfile switch from yarn / yarn install to npm ci, npm run prepare, npm test, and related npm script invocations (including dev sucrase via npm install --save-dev).

Docs & onboarding: README, AGENTS.md, docs/MAESTRO.md, and maestro.sh replace Yarn commands and drop global Yarn installation from the Maestro bootstrap script; README adds a note that the project migrated from Yarn to npm.

No application/runtime wallet code changes—tooling and contributor docs only.

Reviewed by Cursor Bugbot for commit e7bcbe8. Bugbot is set up for automated code reviews on this repo. Configure here.

j0ntz and others added 2 commits June 2, 2026 11:43
- Replace yarn.lock with package-lock.json (generated via
  socket npm install for Socket.dev scanning).
- Swap package.json `resolutions` for npm `overrides`, drop
  `yarn` and `yarn-deduplicate` devDeps, bump `patch-package`
  to ^8, set `packageManager` to npm@11.15.0, and update the
  `fix` script to use `npm dedupe`.
- Persist prior yarn `--ignore-scripts` behavior via
  `ignore-scripts=true` in .npmrc, and add `legacy-peer-deps=true`
  so npm tolerates the same peer-dep conflicts yarn classic did
  (e.g. async-storage@1.19.4 vs RN 0.79).
- Convert yarn invocations to npm equivalents in scripts/prepare.sh,
  Jenkinsfile, .travis.yml, and developer docs (README.md, AGENTS.md,
  docs/MAESTRO.md, webpack.config.js, scripts/gitVersionFile.ts).
- Remove the yarn global-install step from maestro.sh and rename
  the bootstrap function accordingly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedreact-native-custom-tabs@​0.1.8 ⏵ 0.1.800000
Updatedreact-native-store-review@​0.4.3 ⏵ 0.4.300000
Updatedpatch-package@​6.4.7 ⏵ 8.0.197100100 +181100
Updatedreact-native-reanimated@​3.19.1 ⏵ 3.19.597 +110089 +198 +1100

View full report

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Low adoption: npm hashes-grs

Location: Package overview

From: package-lock.jsonnpm/edge-currency-plugins@3.9.0npm/hashes-grs@1.2.0

ℹ Read more on: This package | This alert | What are unpopular packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Unpopular packages may have less maintenance and contain other problems.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/hashes-grs@1.2.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@j0ntz
Copy link
Copy Markdown
Contributor Author

j0ntz commented Jun 2, 2026

Closing — this was an end-to-end orchestration smoke test on a newly provisioned machine, not a real change. The large diff (+28k/-19k) is the in-flight yarn→npm migration commit that setup-task-workspace cherry-picks into every agent worktree; since that migration isn't on develop yet, it leaked into the PR. The actual task was a one-line README note. No merge intended.

@j0ntz j0ntz closed this Jun 2, 2026
@j0ntz j0ntz deleted the agent/1215342253893506 branch June 2, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant