Clarify npm (not yarn) usage in README setup#6019
Conversation
- Replace yarn.lock with package-lock.json (generated via socket npm install for Socket.dev scanning). - Swap package.json `resolutions` for npm `overrides`, drop `yarn` and `yarn-deduplicate` devDeps, bump `patch-package` to ^8, set `packageManager` to npm@11.15.0, and update the `fix` script to use `npm dedupe`. - Persist prior yarn `--ignore-scripts` behavior via `ignore-scripts=true` in .npmrc, and add `legacy-peer-deps=true` so npm tolerates the same peer-dep conflicts yarn classic did (e.g. async-storage@1.19.4 vs RN 0.79). - Convert yarn invocations to npm equivalents in scripts/prepare.sh, Jenkinsfile, .travis.yml, and developer docs (README.md, AGENTS.md, docs/MAESTRO.md, webpack.config.js, scripts/gitVersionFile.ts). - Remove the yarn global-install step from maestro.sh and rename the bootstrap function accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Closing — this was an end-to-end orchestration smoke test on a newly provisioned machine, not a real change. The large diff (+28k/-19k) is the in-flight yarn→npm migration commit that setup-task-workspace cherry-picks into every agent worktree; since that migration isn't on develop yet, it leaked into the PR. The actual task was a one-line README note. No merge intended. |
Description
Asana task
Docs-only change for an end-to-end agent-pipeline smoke test (Asana task).
Adds a short clarifying sentence to the README "Getting Started" section noting that the project previously used yarn but has since migrated to npm, so contributors should use the
npmcommands rather thanyarn.The original task was drafted before the yarn→npm migration and literally asked for a "uses yarn (not npm)" note. Since the repo now uses npm (yarn.lock removed, package-lock.json present, README commands all use
npm), that literal note would be inaccurate. The accurate, value-adding version is committed instead.Note: this branch is based on a worktree that has the (not-yet-on-develop) "Convert package manager from yarn to npm" commit cherry-picked in for tooling. The only commit that is this task's work is the single README change (
Clarify npm (not yarn) usage in README setup); the npm-migration diff will disappear from this PR once that change lands on develop.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
No GUI changes — documentation only.
Note
Low Risk
Changes are limited to install/CI configuration and documentation; no auth, payment, or app runtime logic is modified.
Overview
This PR standardizes the repo on npm instead of Yarn for installs, scripts, and CI.
Configuration:
.npmrcgainsignore-scripts=trueandlegacy-peer-deps=true(behavior previously in.yarnrc, which is removed).package.jsonalready pinspackageManagerto npm.CI / automation: Travis and the Jenkinsfile switch from
yarn/yarn installtonpm ci,npm run prepare,npm test, and related npm script invocations (including devsucrasevianpm install --save-dev).Docs & onboarding: README, AGENTS.md, docs/MAESTRO.md, and maestro.sh replace Yarn commands and drop global Yarn installation from the Maestro bootstrap script; README adds a note that the project migrated from Yarn to npm.
No application/runtime wallet code changes—tooling and contributor docs only.
Reviewed by Cursor Bugbot for commit e7bcbe8. Bugbot is set up for automated code reviews on this repo. Configure here.